Skip to content

libsyntax: Separate multiple inherited traits with + - #5229

Closed
pcwalton wants to merge 2 commits into
rust-lang:incomingfrom
pcwalton:inherited-trait-plus
Closed

libsyntax: Separate multiple inherited traits with + #5229
pcwalton wants to merge 2 commits into
rust-lang:incomingfrom
pcwalton:inherited-trait-plus

Conversation

@pcwalton

@pcwalton pcwalton commented Mar 5, 2013

Copy link
Copy Markdown
Contributor

r? @brson

@pcwalton pcwalton closed this Mar 6, 2013
@pcwalton
pcwalton deleted the inherited-trait-plus branch March 6, 2013 00:26
bors added a commit to rust-lang-ci/rust that referenced this pull request May 2, 2020
Whitelist unused attribute for use items.

This PR whitelists the `unused` attribute with `use` items and adds a corresponding test case.

Fixes: rust-lang#5229
changelog: none
RalfJung pushed a commit to RalfJung/rust that referenced this pull request Aug 2, 2026
…s-and-types-handling

[Priroda] Render projected locals with source-shaped values
U007D pushed a commit to U007D/rust-mos that referenced this pull request Aug 21, 2026
5229: Improve client logging (use output channel and more log levels) r=matklad a=Veetaha

The improvements:
* Separate output channel allows viewing the logs belonging to only our extension (without the intervention of other vscode extensions)
* All the objects in the output channel are always expanded so users only need to `Ctrl + A and Ctrl + C` to copy the entire output to send us and nothing more (e.g. currently users need to expand the object which is not obvious for them and we may lose the logs this way, see two comments: rust-lang/rust-analyzer#5009 (comment)
* More log levels allows us to be more granular in disabling only optional verbose debug-level output and leave the logs for us as developers to understand the context of user issues.
* For `log.error(...)` invocations we reveal `Rust Analyzer Client` channel automatically so that users don't have to do any additional actions to get the logs output window visible

Demo:
![image](https://user-images.githubusercontent.com/36276403/86535275-d7795f80-bee7-11ea-8c30-135c83c1bc7d.png)



Co-authored-by: Veetaha <veetaha2@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants