SocketAddr of Unix Sockets use sun_len as path's length in BSD-like OSes

[zonyitoo]

• fixes SocketAddr from UnixDatagram recv_from missing the last character (on OS X) #69061

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @yaahc (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[zonyitoo]

Hello @yaahc , please take a look this simple PR.

[yaahc]

Looks good @zonyitoo, thank you very much.

@bors r+

[bors]

📌 Commit 6c65a13 has been approved by yaahc

[JohnTitor]

@bors r- see the CI failure.

[yaahc]

@bors r- see the CI failure.

shit, ty

[zonyitoo]

What.. cfg_if does not exist?

[zonyitoo]

Ah... Again, approval required. @yaahc

[rust-log-analyzer]

The job x86_64-gnu-llvm-10 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

thread '<unnamed>' panicked at 'explicit panic', library/std/src/io/stdio/tests.rs:36:9
.................................................................................................... 400/875
.................................................................................................... 500/875
thread '<unnamed>' panicked at 'assertion failed: `(left == right)`
  left: `[104, 101, 108, 108, 111]`,
 right: `[0, 0, 0, 0, 0]`', library/std/src/os/./unix/net/tests.rs:49:9
...........................F........................................................................ 600/875
thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', library/std/src/sync/mpsc/sync_tests.rs:383:27
thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: SendError { .. }', library/std/src/sync/mpsc/sync_tests.rs:371:24
thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', library/std/src/sync/mpsc/sync_tests.rs:250:19
thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', library/std/src/sync/mpsc/tests.rs:322:28
---
thread '<unnamed>' panicked at 'Box<dyn Any>', library/std/src/thread/tests.rs:205:33
...........................................................................
failures:

---- os::imp::unix::net::tests::basic stdout ----
thread 'os::imp::unix::net::tests::basic' panicked at 'assertion failed: `(left == right)`
  left: `Some("/tmp/rust-783326236/sock")`,
 right: `Some("/tmp/rust-783326236/soc")`', library/std/src/os/./unix/net/tests.rs:54:5

failures:
    os::imp::unix::net::tests::basic


test result: FAILED. 874 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 10.31s

error: test failed, to rerun pass '-p std --lib'


command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "x86_64-unknown-linux-gnu" "-Zbinary-dep-depinfo" "-j" "16" "--release" "--locked" "--color" "always" "--features" "panic-unwind backtrace compiler-builtins-c" "--manifest-path" "/checkout/library/test/Cargo.toml" "-p" "std" "--" "--quiet"


failed to run: /checkout/obj/build/bootstrap/debug/bootstrap --stage 2 test --exclude src/tools/tidy
Build completed unsuccessfully in 0:18:03

[yaahc]

Looks like it's still failing @zonyitoo.

[zonyitoo]

I am going to send a PR to cpython instead, because what Rust did right here is completely correct.