Skip to content

skip binder before erasing.#98628

Closed
oli-obk wants to merge 1 commit into
rust-lang:masterfrom
oli-obk:skip_perf_binder
Closed

skip binder before erasing.#98628
oli-obk wants to merge 1 commit into
rust-lang:masterfrom
oli-obk:skip_perf_binder

Conversation

@oli-obk

@oli-obk oli-obk commented Jun 28, 2022

Copy link
Copy Markdown
Contributor

r? @ghost

see if this addresses some of the perf regression in #98109

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 28, 2022
@oli-obk

oli-obk commented Jun 28, 2022

Copy link
Copy Markdown
Contributor Author

@bors try @rust-timer queue

@rust-timer

Copy link
Copy Markdown
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 28, 2022
@bors

bors commented Jun 28, 2022

Copy link
Copy Markdown
Collaborator

⌛ Trying commit d25d79d with merge 8e7eff8a806384acdbaeb38b2787ad4b880505d4...

@bors

bors commented Jun 28, 2022

Copy link
Copy Markdown
Collaborator

☀️ Try build successful - checks-actions
Build commit: 8e7eff8a806384acdbaeb38b2787ad4b880505d4 (8e7eff8a806384acdbaeb38b2787ad4b880505d4)

@rust-timer

Copy link
Copy Markdown
Collaborator

Queued 8e7eff8a806384acdbaeb38b2787ad4b880505d4 with parent 00ebeb8, future comparison URL.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (8e7eff8a806384acdbaeb38b2787ad4b880505d4): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results
  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 🎉 relevant improvements found
mean1 max count2
Regressions 😿
(primary)
N/A N/A 0
Regressions 😿
(secondary)
N/A N/A 0
Improvements 🎉
(primary)
N/A N/A 0
Improvements 🎉
(secondary)
-2.9% -3.3% 4
All 😿🎉 (primary) N/A N/A 0

Cycles

This benchmark run did not return any relevant results for this metric.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Footnotes

  1. the arithmetic mean of the percent change

  2. number of relevant changes

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jun 28, 2022
@oli-obk

oli-obk commented Jun 29, 2022

Copy link
Copy Markdown
Contributor Author

Has no effect, closing

@oli-obk oli-obk closed this Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants