cargo fmt doesn't format files in sub-directories in tests #1820

Activity

1. nrc

   added this to the impl period milestone on Sep 18, 2017
2. brauliobz commented on Sep 27, 2017

   

   brauliobz

   on Sep 27, 2017

   More actions

   cargo fmt only formats test code that is reached by cargo test, which basically follows the mod inclusions, from what I could see.

   I tested the following scenario:

   tests/
       root_test.rs
       subdir/
           mod.rs
           sub_test.rs
   

   sub_test.rs is formatted only when:

   • root_test.rs includes subdir by mod subdir;;
   • and subdir/mod.rs includes sub_test.rs by mod sub_test;.

   Is this behavior really desirable?
3. nrc commented on Sep 29, 2017

   

   nrc

   on Sep 29, 2017

   Member

   More actions

   I think there are two kinds of cargo test - unit tests, which cargo fmt should reach if they are reachable via module includes (I think this is fine); and integration tests, which are not formatted at all (which we should address, though I'm not really sure how).
4. nrc

   removed this from the impl period milestone on Jan 11, 2018
5. scampi

   added

   P-highHigh priorityHigh priority

   on Apr 8, 2019
6. calebcartwright commented on Sep 4, 2019

   

   calebcartwright

   on Sep 4, 2019

   Member

   More actions

   Just a heads up that I've taken a pass at this and now have a working implementation locally.

   Will open a PR for discussion/review/etc. within the next day or two

   ❤️React with ❤️1Reacted by Bráulio Bezerra
7. topecongiro

   closed this as completedin #3777on Oct 29, 2019