[breaking change] fixes unsoundness in avx non-temporal store APIs. - #576
Merged
Conversation
Contributor
Author
|
The appveyor build failures appear unrelated. |
lu-zero
approved these changes
Oct 5, 2018
Contributor
Author
|
@alexcrichton I'd guess we have to create an upstream rust-lang/rust PR that advances stdsimd to this PR so that we can do a crater run, correct? |
Member
|
I've pushed this to https://github.com/rust-lang-nursery/stdsimd/tree/test-fix and yeah we'll need to send a PR to rust-lang/rust to run crater. This also looks good to me, thanks! Want to send a PR pointed to the branch at https://github.com/rust-lang-nursery/stdsimd/tree/test-fix to rust-lang/rust and we'll run crater? |
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Oct 31, 2018
Update stdsimd to branch with breaking bugfix **DO NOT MERGE** --- This updates `stdsimd` to the `test-fix` branch containing this PR (rust-lang/stdarch#576) with a breaking soundness bugfix. The plan was to schedule a crater run before merging this PR into stdsimd upstream. r? @alexcrichton
Member
|
Merging due to the lack of breakage evidence discovered in rust-lang/rust#55538 |
Member
|
er, the other button... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These APIs write through the pointer, so the pointer should be
*mutand not*const.Closes #575 .