Skip to content

Shape<D> and StrideShape<D> should be merged #367

@termoshtt

Description

@termoshtt

I am confusing around Shape<D>, StrideShape<D>, Dim, and &[Ix]. In my understanding, these can be grouped as follow:

  • Has stride information, i.e. these know how the values are aligned in the memory
    • Shape<D>
    • StrideShape<D>
  • Only the size of each dimensions
    • Dim
    • &[Ix]

And each of types in a group should be merged. I think StrideShape<D> and Dim are enough.
Since ArrayBase<S, D> already has stride: D, StrideShape<D> is appropriate, and it should be re-named Shape<D> instead. Associated to this, ShapeBuilder should be also simplified to generate StrideShape<D> (and renamed to IntoShape similar to IntoDimension).

What do you think?
If you agree, I will create PR :)

Thanks!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions