Repository navigation
Task: rustfmt #1429
Description
We should apply rustfmt to the project, probably with #[rustfmt::skip] in some places, and add a CI check. It's going to conflict with a bunch of open PRs, but we always have some.
@MichaelOwenDyer are you interested?
Activity
MichaelOwenDyer commentedon Apr 3, 2024
Sure thing. How do you feel about a pre-commit hook as well?
dhardy commentedon Apr 3, 2024
Thanks. While format-before-commit is good practice, I'm not keen on the idea of tools changing code right before a commit, so no.
dhardy commentedon Apr 3, 2024
Sorry, it's probably worth getting #1424 sorted before a more general reformat.
newpavlov commentedon Apr 3, 2024
It's also worth to add Clippy job to CI (with a fixed toolchain version) and fix existing warnings (29 on current Nightly) in the same PR.
MichaelOwenDyer commentedon Apr 4, 2024
I ran rustfmt locally to see how severe the changes would be and it looks generally quite manageable, I only identified a couple files where we might want to sprinkle in
#[rustfmt::skip]. I'll wait for #1424 to be merged before opening a PR.Good idea 👍🏽
dhardy commentedon May 8, 2024
We should merge #1447 once CI is done, then we can work on this. I can do so, but since @newpavlov offered?
Additional suggestion: move the rand_core traits into a private sub-module.