[BUG] pkg.component.prometheus.service.args arguments is not working #61

Activity

1. MurzNN

   added

   bugSomething isn't workingSomething isn't working

   on Jun 29, 2021
2. B1ue-W01f commented on Jun 29, 2021

   

   B1ue-W01f

   on Jun 29, 2021

   More actions

   See #59

   Theres an open pull request solving this issue.
3. MurzNN commented on Jun 29, 2021

   

   MurzNN

   on Jun 29, 2021

   Author

   More actions

   Thanks, I saw that issue, but it is for environment variables, but my - for arguments, but if the solution is same - that's good!
4. B1ue-W01f commented on Jun 29, 2021

   

   B1ue-W01f

   on Jun 29, 2021

   More actions

   Yeah prometheus can have these config options passed into the service file or the environ file. Previously it was partially implemented, but ultimately not working for either.

   When the pull request is complete, this will work through the environ piller in the same format as you gave above, i.e.:

   prometheus:
     pkg:
       use_upstream_repo: true
       use_upstream_archive: false
       component:
         prometheus:
           environ:
             args:
               web.listen-address: 192.168.1.1:9191
               enable-feature: remote-write-receiver
   

   Im based off the repo my pull is from and the above pillar deploys the correct config.
5. MurzNN commented on Jul 12, 2021

   

   MurzNN

   on Jul 12, 2021

   Last edited by MurzNN

   Author

   More actions

   I updated to v5.5.1, but this still not working, here is my part of the pillar:

         prometheus:
           version: v2.28.0
           archive:
             source_hash: d2d0ded275090a13208114b633abe41c40e14c83ff5ec07230d79b4da1d8e701
           service:
             args:
               web.listen-address: localhost:9091
               enable-feature: remote-write-receiver
           environ:
             args:
               web.listen-address: localhost:9092
               enable-feature: remote-write-receiver2
   

   It applies successfully, but in /etc/systemd/system/multi-user.target.wants/prometheus.service I still don't see those arguments appeared:

   ExecStart=/opt/prometheus/prometheus-v2.28.0/prometheus --config.file /etc/prometheus/prometheus.yml
   

   Where can be the problem?
6. B1ue-W01f commented on Jul 12, 2021

   

   B1ue-W01f

   on Jul 12, 2021

   More actions

   You wont see them in the service because as mentioned the formula does not handle service args - it never did.

   service: args: web.listen-address: localhost:9091 enable-feature: remote-write-receiver
   <<Does nothing.

   Because of the environ section, you should however see that the service file makes reference to an environment file (that's how your package repo should install it, though some OS's don't include it for some reason) and that environment file will include those args.

   On debian it will be: /etc/default/prometheus
7. MurzNN commented on Jul 12, 2021

   

   MurzNN

   on Jul 12, 2021

   Last edited by MurzNN

   Author

   More actions

   I tried both (server and environ) to see something as working :)
   In /etc/default/prometheus I see no changes too, seems because I use use_upstream_repo: false? In Debian repo there is too old version of prometheus, so I have to install from upstream archive. So this feature will not work with use_upstream_archive mode?
8. B1ue-W01f commented on Jul 12, 2021

   

   B1ue-W01f

   on Jul 12, 2021

   Last edited by B1ue-W01f

   More actions

   The formula is essentially split in two based on the use of 'use_upstream_archive'.

   The 'use_upstream_archive' essentially ignores all of the code I updated, so I have no idea if it should work or not.

   If you look at the archive section of the formula, it looks like its supposed to, with this being the key bit:

   env: {{ p.pkg.component[name]['service'].get('env', [])|tojson }}
   

   So perhaps its looking for a different pillar again.
9. Ahummeling commented on Feb 2, 2022

   

   Ahummeling

   on Feb 2, 2022

   Contributor

   More actions

   I'm running into problems with this as well, specifically for the --storage.tsdb.retention.time flag.
   After going through the formula for a while I noticed something interesting the in the way the ExecStart directive of the prometheus (component) unit file gets constructed:

   {%- if name in ('node_exporter', 'consul_exporter') or 'config_file' not in p.pkg.component[name] %}
                    {%- set args = [] %}
                    {%- for param, value in p.pkg.component.get(name).get('service').get('args', {}).items() %}
                       {%- if value is not none %}
                         {% do args.append("--" ~ param ~ "=" ~ value ) %}
                       {%- else %}
                         {% do args.append("--" ~ param ) %}
                       {%- endif %}
                    {%- endfor %}
           start: {{ p.pkg.component[name]['path'] }}/{{ name }} {{ args|join(' ') }}
                  {%- else %}
           start: {{ p.pkg.component[name]['path'] }}/{{ name }} --config.file {{ p.pkg.component[name]['config_file'] }}  # noqa 204
                  {%- endif %}

   If I am not mistaken, omitting all args from the start variable here, we would never be able to add commandline flags to the prometheus service, but Prometheus docs seem to suggest that there are some settings that can only be configured through the commandline flags.
   Admittedly, the variables will be added to the env file just fine when configured to do so, but the prometheus executable seems to start the TSDB before loading this env file, and as a result, certain flags (such as the retention time) cannot be modified. The only way to set them, is by providing the appropriate command line flags.

   I ended up creating sort of a dirty fix, but I'll open a PR anyway, maybe it can end up being useful in some way.
   pr: #74

   👍React with 👍1Reacted by Gabriel Soudry
10. gabrielSoudry commented on Feb 10, 2022

    

    gabrielSoudry

    on Feb 10, 2022

    More actions

    Same problem as above, with the feature flag agent

            service:
              args:
                web.listen-address: localhost:9091
                enable-feature: agent