Clean up JS, move options to yaml file - #1
Merged
Merged
Conversation
|
👍 |
|
@sandraor - Please review, but this looks good to me (thanks @yaymukund!). When you merge this PR (which is against your repo), these commits will automatically be included into the main PR (emberjs#1904). |
sandraor
added a commit
that referenced
this pull request
Jan 9, 2015
Clean up JS, move options to yaml file
Owner
|
Thanks @yaymukund and @rwjblue! |
sandraor
pushed a commit
that referenced
this pull request
Jan 11, 2015
Integrate column balancer with new meetups.yml structure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I read emberjs#1904 and thought I'd take a stab at cleaning up the JS. This branch does two things: