Conversation
…apshot its own connect budget
Owner
Author
|
Superseded by the upstream PR pingdotgg#14518 (issue pingdotgg#14516). Fixes go upstream, not to the fork. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Pin the connect budget fix, a clean cherry-pick of the same change proposed for upstream (branch
fix/client-snapshot-timeout). Forkmaincarries release configuration, not V2 source, so this PR only appends the manifest entry. The source commit is on the branch named below. Incident:research/t3-v2-server-update-outage-2026-09-30.md. Pins append at the end of.github/downstream-nightly-v2.json, so the PRs in this series conflict textually; whichever merges later rebases and keeps every entry. CI on this fork has been stuck, so verification is local.Why
The client's 15 second establishment timeout covered the whole attempt, including the wait for the first
subscribeServerConfigsnapshot. A cold server with a 33 GB database missed it, so the desktop tore down a healthy websocket and looped connect, interrupt, retry for 10 minutes. The 15 seconds now covers resolving credentials and creating the session; once the driver reports the synchronizing stage, 75 more seconds cover the socket open (still capped at 15 by the RPC session) and the snapshot. Shared supervisor, so web, desktop and mobile all get it.Verification
vp test run packages/client-runtime/src/connection/supervisor.test.ts: 39 passed, including a 40 second snapshot that now connects on the first attempt and a never-ready session that still fails at 75 seconds.d0c468e3e51).Implementation: Claude Sonnet 5.5 through T3 Code. Cross-vendor review: GPT-6 Astra (high) via
codex execread-only, because T3delegate_taskreported the Codex provider unavailable.🤖 Generated with Claude Code