Skip to content
This repository was archived by the owner on Oct 24, 2025. It is now read-only.

Show sass file on the top of backtrace - #34

Merged
bolandrm merged 2 commits into
sass:masterfrom
k0kubun:sass_backtrace
Jun 22, 2016
Merged

Show sass file on the top of backtrace#34
bolandrm merged 2 commits into
sass:masterfrom
k0kubun:sass_backtrace

Conversation

@k0kubun

@k0kubun k0kubun commented Jan 15, 2016

Copy link
Copy Markdown
Contributor

When SyntaxError is raised, I want to see the broken sass file on error page. This is implemented in Sass::SyntaxError too.
Since we can know filename and lineno only from message, I implemented it by parsing it.

Screen shot

before

2016-01-15 18 50 26

after

2016-01-15 18 50 57

@k0kubun

k0kubun commented Jan 26, 2016

Copy link
Copy Markdown
Contributor Author

@bolandrm How do you think about this? Is there any blocker to merge? I want this patch to find what is wrong easily in development.

@bolandrm

Copy link
Copy Markdown
Member

It looks good, no blockers. I just need to get some time to review and test it and then I will merge.

@k0kubun

k0kubun commented Jan 26, 2016

Copy link
Copy Markdown
Contributor Author

Thank you for your comment! I'm looking forward to being reviewed.

@bolandrm

Copy link
Copy Markdown
Member

Sorry for the delay, I'll merge this in when I do the next update for libsass 3.3.6.

@bolandrm
bolandrm merged commit f8b95c5 into sass:master Jun 22, 2016
@k0kubun
k0kubun deleted the sass_backtrace branch June 22, 2016 23:01
@bolandrm

Copy link
Copy Markdown
Member

Hey, I did merge this in, but I made some changes so that we're using the filename and line number information for libsass.

73397b6

it's working in my application, but let me know if you have any issues. thanks for the contribution!

@k0kubun

k0kubun commented Jun 23, 2016

Copy link
Copy Markdown
Contributor Author

Hi. First of all, thank you for merging this PR! I confirmed your changes and changed my application to use sassc-ruby v1.10.0. I tried some invalid scss and it worked fine. I'll report an issue if I find.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants