fix(cli): propagate scan --wfp failure to exit code (SP-4512) - #223
Merged
Conversation
The scan --wfp branch discarded the return value of scan_wfp_with_options, so a failed WFP scan always exited 0 even though no results file was produced. This was inconsistent with the folder, STDIN and dependency scan modes, which map failure to a non-zero exit, and broke CI pipelines that rely on the exit code to detect failures. Wrap the call in the same 'if not ...: sys.exit(1)' guard used by the other scan branches, and add regression tests asserting a failed --wfp scan exits non-zero and does not leave partial results behind.
📝 WalkthroughWalkthroughThe ChangesWFP scan failure handling
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related issues
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
SCANOSS SCAN Completed 🚀
View more details on SCANOSS Action Summary |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes SP-4512:
scanoss-py scan --wfp <file>always exited0, even when the scan failed.The
--wfpbranch in thescanhandler discarded the return value ofscanner.scan_wfp_with_options(...), so a failed WFP scan reported success. This was inconsistent with every other scan mode (folder, STDIN,--files, dependency), which map failure to a non-zero exit, and it broke CI pipelines that rely on the exit code to detect failures.