Support for reading auth env vars from .env file#195
Open
elacuesta wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #195 +/- ##
==========================================
- Coverage 93.82% 93.80% -0.02%
==========================================
Files 28 28
Lines 1958 1968 +10
==========================================
+ Hits 1837 1846 +9
- Misses 121 122 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Comment on lines
+41
to
+44
| Instead of exporting the variable yourself, you can store it in a ``.env`` | ||
| file and let the client load it:: | ||
|
|
||
| SH_APIKEY=84c87545607a4bc0**************** |
Contributor
There was a problem hiding this comment.
Same 💄 suggestion as in the other PR 🙂
Comment on lines
+142
to
+148
| # Fall back to the .env file only when the environment has no usable | ||
| # credentials, so an exported key never triggers a file lookup. | ||
| if not apikey and not jobauth: | ||
| dotenv = _read_dotenv_auth(dotenv_path) | ||
| apikey = next((dotenv[var] for var in _APIKEY_VARS | ||
| if dotenv.get(var)), None) | ||
| jobauth = dotenv.get('SHUB_JOBAUTH') |
Contributor
There was a problem hiding this comment.
So if SH_APIKEY is set as an env var but SHUB_JOBAUTH is not, a .env SH_APIKEY takes over the env var?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to scrapinghub/shub#476