Repository navigation
Fix inject_global_value rules with default value - #324
Merged
Merged
Conversation
|
Coverage after merging fix-inject-global-default-value into main will be
Coverage Report for Changed Files
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Stefanuk12
added a commit
to Stefanuk12/darklua
that referenced
this pull request
Dec 28, 2025
* Fix `inject_global_value` rule with default value (seaofvoices#324) * Release 0.17.3 (seaofvoices#325) * Add support for property modifiers in table types (seaofvoices#332) This PR adds support for `read` and `write` access modifiers in table types. Example: ``` export type Object = { read name: string, } ``` --------- Co-authored-by: jeparlefrancais <35781636+jeparlefrancais@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #321
This fixes an issue with how the default value defined in
inject_global_valuecould override the environment value even it was specified.