Skip to content

Fix inject_global_value rules with default value - #324

Merged
jeparlefrancais merged 5 commits into
mainfrom
fix-inject-global-default-value
Nov 27, 2025
Merged

jeparlefrancais merged 5 commits into
mainfrom
fix-inject-global-default-value

Conversation

@jeparlefrancais

@jeparlefrancais jeparlefrancais commented Nov 27, 2025 •

Copy link
Copy Markdown
Contributor

Closes #321

This fixes an issue with how the default value defined in inject_global_value could override the environment value even it was specified.

  • add entry to the changelog

@github-actions

Copy link
Copy Markdown

Coverage after merging fix-inject-global-default-value into main will be

87.30%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
src/frontend
   configuration.rs87.63%100%86.96%87.75%142–156, 158–159, 196–200, 59–61, 72–75
   work_item.rs90.29%100%90.48%90.24%107–109, 150, 155–158
src/process/evaluator
   lua_value.rs93.20%100%92.59%93.33%153–155, 165–167, 54, 68
src/rules
   append_text_comment.rs81.55%100%87.50%80.92%102–105, 123–124, 167–172, 201–203, 32–38, 49, 51–54
   inject_value.rs86.75%100%93.55%86.01%180, 187, 195–204, 206–215, 220–226, 232, 240–242, 74, 78–79
   remove_interpolated_string.rs94.89%100%100%94.38%209–216
src/rules/convert_require
   roblox_index_style.rs100%100%100%100%

@jeparlefrancais
jeparlefrancais merged commit fa7bd9d into main Nov 27, 2025
6 checks passed
@jeparlefrancais
jeparlefrancais deleted the fix-inject-global-default-value branch November 27, 2025 21:52
Stefanuk12 added a commit to Stefanuk12/darklua that referenced this pull request Dec 28, 2025
* Fix `inject_global_value` rule with default value (seaofvoices#324)

* Release 0.17.3 (seaofvoices#325)

* Add support for property modifiers in table types (seaofvoices#332)

This PR adds support for `read` and `write` access modifiers in 
table types.

Example:
```
export type Object = {
    read name: string,
}
```

---------

Co-authored-by: jeparlefrancais <35781636+jeparlefrancais@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix inject_global_value rule default value overrides

1 participant