Add TFTP options to DHCP - #2765
Merged
Merged
Conversation
- fix issue 2747 - also update random tests
Codecov Report
@@ Coverage Diff @@
## master #2765 +/- ##
==========================================
+ Coverage 88.23% 88.27% +0.03%
==========================================
Files 251 252 +1
Lines 53367 53472 +105
==========================================
+ Hits 47091 47201 +110
+ Misses 6276 6271 -5
|
guedou
requested changes
Sep 4, 2020
guedou
left a comment
guedou
left a comment
Member
There was a problem hiding this comment.
Thanks for your PR. Could you also add 128 (see https://www.iana.org/assignments/bootp-dhcp-parameters/bootp-dhcp-parameters.xhtml)?
guedou
reviewed
Sep 7, 2020
| 118: IPField("subnet-selection", "0.0.0.0"), | ||
| 124: "vendor_class", | ||
| 125: "vendor_specific_information", | ||
| 128: IPField("tftp-server-ip-address", "0.0.0.0"), |
Member
There was a problem hiding this comment.
Could you use _ instead of - to be consistent with your modifications? Thanks. Otherwise, this looks good to be merged.
"-" > "_"
guedou
approved these changes
Sep 8, 2020
bzalkilani
pushed a commit
to bzalkilani/scapy
that referenced
this pull request
Jun 12, 2022
* Add TFTP options to DHCP - fix issue 2747 - also update random tests * Update dhcp.py * Update dhcp.py "-" > "_"
bzalkilani
pushed a commit
to bzalkilani/scapy
that referenced
this pull request
Jun 14, 2022
* Add TFTP options to DHCP - fix issue 2747 - also update random tests * Update dhcp.py * Update dhcp.py "-" > "_"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix 2747
adding tftp options in DHCP layer:
scapy/scapy/layers/dhcp.py