Repository navigation
docs(infrastructure): normalize structure and wording - #583
Merged
Merged
Conversation
Add Key Takeaways, overview page map with DNS subsection, related frameworks, IAM pointer fix to /iam/overview, and contributor roles. Preserve DNS incident and control bodies.
Deploying frameworks with
|
| Latest commit: |
9cb27d2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://295d0998.frameworks-573.pages.dev |
| Branch Preview URL: | https://docs-normalize-infrastructur.frameworks-573.pages.dev |
Match develop authorship exactly. Clear wrote/reviewed/fact-checked arrays where normalization invented authors on pages that had none. Do not attribute chrome-only edits as content authorship.
Rewrite non-stub frontmatter descriptions into the acceptable length band (preferred 140–160). Stub pages exempt. No body or credit changes.
Rename Further Reading H2s to the exact title the updated #561 validator accepts; sentence-case a few common section headings.
Child pages missing a canonical further/related H2 failed the updated #561 validator. Add a minimal Further Reading block linking the framework overview.
Neutralize fence comments that look like headings, canonicalize overview page-map titles, clamp descriptions, demote excess H2s, and mark template pages with content-model exceptions.
frameworks-volunteer
approved these changes
Aug 5, 2026
frameworks-volunteer
left a comment
frameworks-volunteer
left a comment
Collaborator
There was a problem hiding this comment.
Model: z-ai/glm-5.2 Reasoning: medium Provider: openrouter
Reviewed PR #583: docs(infrastructure): normalize structure and wording.
Security review: No issues. No secrets, injection vectors, or unsafe patterns. The broken IAM link ("Incident and Access Management" -> /iam/access-management) is correctly fixed to "Identity and Access Management (IAM)" with proper paths (/iam/overview, /iam/access-management).
QA review:
- All 29 internal links resolve to existing files
- External links are legitimate (NIST, CIS, ICANN, AWS, internet.nl, GitHub repos)
- Heading casing normalized consistently (Best Practices -> Best practices, Key Principles -> Key principles, Further Reading & Tools -> Further Reading)
- Key Takeaways added to all 13 pages
- Further Reading sections added with descriptive link text
- DNS overview now includes child page map (What this framework covers)
- Infrastructure overview expanded with subsection map and Related frameworks
- Contributors frontmatter added with empty arrays (consistent with other normalize PRs)
- No leftover debug content, TODOs, or placeholders
- CI: lint, sidebar-reminder, Cloudflare Pages, Socket Security all pass
Minor non-blocking notes:
- 3 descriptions are 122-138 chars (under the 140 preferred floor but within the 120-170 acceptable band per the clamp commit)
- Some descriptions end mid-phrase ("open-source tools like", "You cannot protect what you do not") -- consistent with the clamping approach used across all normalize PRs
Approving.
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Normalize Infrastructure (
docs/pages/infrastructure/including domain-and-dns-security/).Why
Thin overview TOC; missing Key Takeaways; IAM page linked incorrectly to a mangled path (“Incident and Access Management”); DNS overview lacked child page map.
Substantive security changes
None beyond correcting the broken IAM internal link to
/iam/overviewand/iam/access-management.Validation
Dependencies
#561 by reference.
Reviewer focus