Repository navigation
fix(certs): move Auditor Accreditation page to /certs/auditor-accreditation - #653
Open
eastagiletracker wants to merge 1 commit into
Conversation
…tation The page was reworked into Auditor Accreditation but kept the old /certs/certified-partners route and the "Certified Partners" sidebar label. Rename the route, update the sidebar entry and internal links, and add 301 redirects from the old path (with and without trailing slash) so existing inbound links keep resolving.
Sidebar Configuration ReminderThis PR includes added, renamed, or removed documentation files:
Please ensure that:
See Contributing guidelines - Sidebar / Navigation for more details. This is an automated reminder. If this PR doesn't need sidebar changes, you can ignore this message. |
Collaborator
|
Hi @eastagiletracker, thanks for this contribution! Before we review the changes, a quick heads up: the commits in this PR aren't showing as verified, and we need them signed before we can merge. Happy to help if needed :)) |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes moving the Auditor Accreditation page from
/certs/certified-partnersto/certs/auditor-accreditation, with 301 redirects from the old path (Fixes #524). We include this PR work along with a full history of your repo at https://eastagiletracker.com/projects/693. You can sign in with your GitHub ID to claim ownership of the project.What does this PR change?
After #520 reworked the page into Auditor Accreditation, the site still served it at
/certs/certified-partnersunder a "Certified Partners" sidebar label, and/certs/auditor-accreditationdid not exist. This PR does the four tasks listed in #524: renamesdocs/pages/certs/certified-partners.mdxtoauditor-accreditation.mdx(content unchanged), updates thevocs.config.tssidebar entry to "Auditor Accreditation" with the new link, updates the internal links incerts/overview.mdxand the generatedcerts/index.mdx(plus the matching key inutils/fetched-tags.json, in the order the tags generator writes it), and adds two rules topublic/_redirects, one for/certs/certified-partnersand one for/certs/certified-partners/. Both are needed because Pages canonicalizes directory pages to the trailing-slash form, so inbound links exist in both shapes.Reproduction on current
develop(b8c1e81): afterpnpm run docs:build,dist/public/certs/certified-partners/index.htmlhas the title "Auditor Accreditation | Security Alliance" but the sidebar entry "Certified Partners", and nocerts/auditor-accreditationroute is generated.Verification: I served each build's
dist/publiclocally withwrangler pages dev, which applies_redirectsthe same way Pages does, and followed redirects withcurl -sL:As a control, I served the new build with the old
_redirectsfile. All three old URLs returned 404, so the redirect rules are what keep existing links working.pnpm run docs:buildsucceeds, andgrep -r certified-partners dist/publicnow matches only_redirects. The llms output and the search index pick up the new route.test:security-map(29/29),validate:security-map, and cspell and markdownlint ondocs/pages/certspass as they did before the change.validate:contentreports the same issue set as ondevelop: the page's existingdescription_long:175note now appears under the new filename.How this was managed
This change was tracked as story 27y on the SEAL Frameworks board, which was imported from this repo's 620 issues and pull requests and used to manage this work.
If you'd rather not receive contributions like this, reply
no-more-prson this pull request and we won't open any further ones on your repositories.Lawrence W. Sinclair
CEO / East Agile
linkedin.com/in/lwsinclair/
eastagile.com