Repository navigation
security: reject failed reCAPTCHA verifications - #675
Open
obaidur-dev wants to merge 1 commit into
Open
obaidur-dev wants to merge 1 commit into
obaidur-dev wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AuthController::checkRecaptcha()refuses a request only when the verification succeeded with a score below 0.5:When Google answers
success: false, which it does for a forged, expired, replayed or missing token, the condition is false and the login, registration or password recovery request goes through. The check also fails open when the verification endpoint cannot be reached.This change:
Affected release: 3.8.2,
app/Controllers/Auth/AuthController.phplines 16 to 23.Test
tests/Feature/Auth/RecaptchaVerificationTest.phpfakes the verification endpoint with a local stream wrapper (tests/Support/RecaptchaResponseStream.php), so no request leaves the machine. It covers a failed verification, a low score, an unreachable endpoint and a successful verification.Before the fix 2 of the 4 tests fail: the failed verification is accepted and the unreachable endpoint returns 500. After the fix all 4 pass.