You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Use PARALLEL_TESTS_EXECUTABLE environmental variable if it's provided - #66
I would like to use turbo_tests on ruby/ruby same as rubygems/rubygems for testing bundler. see ruby/ruby#12250.
We used parallel_tests because turbo_tests didn't support ENV["PARALLEL_TESTS_EXECUTABLE"] for custom executable on parallel_tests. I added new condition for that around command_name.
Should this be RSPEC_EXECUTABLE or something like that?
My understanding is that PARALLEL_TESTS_EXECUTABLE is a parallel_tests thing that helps in environments where ruby needs to be run differently (like in ruby-core test setup), but the way it's implemented here it's replacing rspec, so the consumer of this library will need to include some command line to help running rspec in the ENV, right?
Should this be RSPEC_EXECUTABLE or something like that?
I have no strong opinion about that. RSPEC_EXECUTABLE is okay to me.
My understanding is that PARALLEL_TESTS_EXECUTABLE is a parallel_tests thing that helps in environments where ruby needs to be run differently (like in ruby-core test setup), but the way it's implemented here it's replacing rspec, so the consumer of this library will need to include some command line to help running rspec in the ENV, right?
Yes. ruby-core need to use miniruby for testing bundler before ruby installation. The current implementation forces to use rspec by gem install or bundle install.
pboling
pushed a commit
to VitalConnectInc/turbo_tests
that referenced
this pull request
Feb 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋 Thank you for maintaining
turbo_tests.I would like to use
turbo_testsonruby/rubysame asrubygems/rubygemsfor testing bundler. see ruby/ruby#12250.We used
parallel_testsbecauseturbo_testsdidn't supportENV["PARALLEL_TESTS_EXECUTABLE"]for custom executable onparallel_tests. I added new condition for that aroundcommand_name.How about this? Thank you for reading this.