Skip to content

Add missing input.name parameter for evaluation of config.name#16

Closed
KowalskiTom wants to merge 2 commits into
serverless-components:masterfrom
KowalskiTom:patch-1
Closed

Add missing input.name parameter for evaluation of config.name#16
KowalskiTom wants to merge 2 commits into
serverless-components:masterfrom
KowalskiTom:patch-1

Conversation

@KowalskiTom

Copy link
Copy Markdown

Add missing input.name parameter for evaluation of config.name

@laardee

laardee commented Nov 18, 2019

Copy link
Copy Markdown
Contributor

@KowalskiTom should the role be named with the same name than the lambda? After your role PR is merged, this could contain also a role name.

Otherwise seems to work as expected.

@KowalskiTom

Copy link
Copy Markdown
Author

@laardee good call. I have added this in.

@KowalskiTom KowalskiTom reopened this Nov 22, 2019
@KowalskiTom KowalskiTom changed the title Update serverless.js Add missing input.name parameter for evaluation of config.name Nov 22, 2019
@Podders

Podders commented Jan 29, 2020

Copy link
Copy Markdown

@eahefnawy any plans to merge this one? It's kind of a needed option in my humble opinion

@nathanmargaglio

Copy link
Copy Markdown

What's stopping this from being merged? I'd be willing to help get this thing up ASAP

@SarKurd

SarKurd commented Feb 28, 2020

Copy link
Copy Markdown

@eahefnawy we desperately need this, could you please review?

@Belco90

Belco90 commented Mar 5, 2020

Copy link
Copy Markdown

Another one here needing this ✋

@JStein92

JStein92 commented Mar 9, 2020

Copy link
Copy Markdown

@eahefnawy we need this as well.

@watanabeyu

Copy link
Copy Markdown

@eahefnawy please merge

@falecci-morean

Copy link
Copy Markdown

Need this as well :)

@eahefnawy

Copy link
Copy Markdown
Member

Thanks all! We rebuilt the entire thing from scratch and updated it for Components V2 and incorporated this change.

@eahefnawy eahefnawy closed this Apr 9, 2020
@andidev

andidev commented Apr 13, 2020

Copy link
Copy Markdown

@eahefnawy
When is this released?

@eahefnawy

Copy link
Copy Markdown
Member

It's already out. Check out the readme:
https://github.com/serverless-components/aws-lambda/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.