Skip to content

Emit error on failed resubscribe#174

Open
gkubisa wants to merge 5 commits into
share:masterfrom
Teamwork:emit-error-on-failed-resubscribe
Open

Emit error on failed resubscribe#174
gkubisa wants to merge 5 commits into
share:masterfrom
Teamwork:emit-error-on-failed-resubscribe

Conversation

@gkubisa

@gkubisa gkubisa commented Oct 17, 2017

Copy link
Copy Markdown
Contributor

Normally when a subscribe callback is missing, an error event is generated on error, except for the following scenario addressed by this PR:

  1. state === 'connecting'
  2. subscribe() - can't subscribe in this state
  3. state === 'connected'
  4. _resubscribe()
  5. Backend returns an error

Expected: doc.emit('error', error)
Actual: no error event

@coveralls

coveralls commented Oct 17, 2017

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.4%) to 96.497% when pulling e97489c on Teamwork:emit-error-on-failed-resubscribe into c0e2fee on share:master.

@gkubisa

gkubisa commented Jun 11, 2018

Copy link
Copy Markdown
Contributor Author

@nateps @ericyhwang , could you provide some feedback on this PR, or merge it, if it's all good, please?

@ericyhwang

ericyhwang commented Jul 11, 2018

Copy link
Copy Markdown
Contributor

Nate's comments, from the PR review meeting:

  • The state machine on reconnecting is interesting.
  • I'll have to look at the rest of the code to check for consistency.

@curran

curran commented Dec 21, 2019

Copy link
Copy Markdown
Contributor

Suggest to close without merging due to lack of activity.

@curran curran mentioned this pull request Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants