Fix hasWritePending in op's callback#205
Open
gkubisa wants to merge 3 commits into
Open
Conversation
2 similar comments
Contributor
Author
|
@nateps @ericyhwang , could you provide some feedback on this PR, or merge it, if it's all good, please? |
Contributor
|
Nate from the PR review meeting:
|
Contributor
|
Suggest to close as stale. |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
doc.hasWritePending()should be false in the op's callback after the last operation is complete.Additionally, checking for
this.inflightOpfirst inthis.inflightOp && this.inflightOp.callbacksavoids a TypeError which would happen, if this _otApply failed and caused a hard rollback. Unfortunately, I don't have a test for this situation, as it's a rather obscure edge case.