Conversation
pc_cf5a5bfa6330 The vendored alchemy-effect subtree recorded .vendor/alchemy as a gitlink without a root .gitmodules entry. Checkout clean runs git submodule foreach and exits 128, so a persistent self-hosted worktree had to be recreated. Remove the pointer instead of vendoring the upstream ~900MB reference checkout or declaring a submodule. Restore persist-credentials: false now that foreach can succeed, and strip the same class of gitlink after subtree sync. Co-authored-by: shuv <shuv1337@users.noreply.github.com>
The checkout regression reads the full index. execFileSync stops at 1MB, and the scripts typecheck rejects node:child_process. Co-authored-by: shuv <shuv1337@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Removes the unmapped gitlink at
.repos/alchemy-effect/.vendor/alchemy(160000c9f5e549) and teachessync:reposto drop nested gitlinks after a subtree add or pull. Restorespersist-credentials: falseon the checkouts that dropped it only to avoidgit submodule foreachdying on this pointer.Fixes #253
Papercut
pc_cf5a5bfa6330.Why
git subtreecopied alchemy-effect's.vendor/alchemysubmodule pointer and did not promote its nested.gitmodulesentry. This repo has no root.gitmodules, sogit submodule statusandgit submodule foreachexit 128 withno submodule mapping found. Checkout clean on a persistent worktree uses that foreach and had to recreate the repository. Lean GitHub-hosted CI still passed because it clones into an empty workspace and had stopped settingpersist-credentials: false.Upstream marks that submodule
update = noneand describes it as a ~900MB reference-only checkout that even alchemy-effect CI skips. The parent repo vendors.repos/as a subtree, so the pointer is removed rather than checked out or declared as a submodule.UI Changes
Checklist
Verification
vp test run scripts/sync-reference-repos.test.ts— 13 passed.git submodule statusandgit submodule foreachnow exit 0 in this checkout.