Skip to content

Show editor fields borderless until focused - #2946

Open
hahn-kev-bot wants to merge 3 commits into
developfrom
fwlite/borderless-fields
Open

hahn-kev-bot wants to merge 3 commits into
developfrom
fwlite/borderless-fields

Conversation

@hahn-kev-bot

@hahn-kev-bot hahn-kev-bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Collaborator

An idea based on the designs I generated

Unfocused Focused
Borderless fields Focused gloss field
Hover Dark mode
Hovered field Dark mode

AI summary

From a manual QA session: entry editor fields now read as plain values separated by a thin divider, instead of a stack of bordered text boxes. The input box and focus ring come back while a field is focused, its dropdown is open, or it's invalid.

  • One scoped stylesheet in editor-root.svelte covers text inputs, rich-text fields, dropdown triggers and the Add audio button. It applies only to states that aren't focused, open or invalid, so each input's own focus styles apply unchanged.
  • Hovering an editable field tints it lightly so it still looks clickable.
  • Everything rendered in Editor.Root picks this up: the entry editor, New Word, picture editing and the Activity change previews.
  • Argos screenshot baselines will change. The docs-site FW Lite screenshots will look outdated until task docs:screenshots is re-run.

Test plan

  • task verify
  • Review the Argos diffs in CI
  • Tab through an entry, and open a dropdown: the box shows on the focused field only

🤖 Generated with Claude Code

hahn-kev and others added 3 commits November 6, 2026 15:55
Entry editor fields now read as plain values separated by a thin
divider. The input box and focus ring only appear while a field is
focused, open or invalid, and hovering an editable field tints it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 3d5b5f64-6654-438c-8c4a-86254c1723d8
Commits

Reviewing files that changed from the base of the PR and between 7187768 and 46ed2b6.

Files selected for processing: 2

  • frontend/viewer/src/lib/components/editor/editor-root.svelte
  • frontend/viewer/src/lib/components/field-editors/audio-input.svelte
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions github-actions Bot added the 💻 FW Lite issues related to the fw lite application, not miniLcm or crdt related label Nov 6, 2026
@argos-ci

argos-ci Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No changes detected - Nov 6, 2026, 9:12 AM

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💻 FW Lite issues related to the fw lite application, not miniLcm or crdt related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants