Skip to content

Added tests checking filters compression - #128

Merged
vasole merged 7 commits into
silx-kit:mainfrom
t20100:test-compressed
Jun 14, 2021
Merged

vasole merged 7 commits into
silx-kit:mainfrom
t20100:test-compressed

Conversation

@t20100

@t20100 t20100 commented Jun 14, 2021

Copy link
Copy Markdown
Member

This PR adds a basic test to make sure compression is actually doing something (when it should)
This follows issue #121, and is a basic way to avoid this in the future.

closes #124

@t20100 t20100 added this to the Next release milestone Jun 14, 2021
@t20100

t20100 commented Jun 14, 2021 •

Copy link
Copy Markdown
Member Author

Now CI should pass.
Tests of compression are based on read_direct_chunk which is only available with h5py>=2.10.

@t20100
t20100 force-pushed the test-compressed branch from d358759 to 244a510 Compare June 14, 2021 09:44
@t20100

t20100 commented Jun 14, 2021

Copy link
Copy Markdown
Member Author

Fixed CI by using an older version of numpy compatible with h5py 2.6.0.
Ready for review.

@vasole
vasole merged commit c043a44 into silx-kit:main Jun 14, 2021
@t20100
t20100 deleted the test-compressed branch October 13, 2021 11:40
t20100 added a commit to t20100/hdf5plugin that referenced this pull request Sep 4, 2023
092190c38 Fix spelling errors (silx-kit#128)
b241ca0d0 Fix the CMake multiconfig var and test and tools handling (silx-kit#127)
7b33e4f19 Fix some make output issues (silx-kit#126)
51d221848 Documentation fixes and fixes from testing 1.1.1 (silx-kit#125)
4ae30429c CMake: (fix) HDF5 1.14.0 (silx-kit#121)
e1072ec5b Update Github actions  (silx-kit#118)
b021532ea Fix leak and consistify generic API with ZFP C API (silx-kit#117)
06408bb22 Enable CMake Testing (silx-kit#116)
eb5440043 Fix version info in docs
ad61dfa41 Revert "rework feat-cmake_tests CMake and replace scripts (silx-kit#111)" (silx-kit#115)
03b86413f rework feat-cmake_tests CMake and replace scripts (silx-kit#111)
08116fa9e Update README.md (silx-kit#114)
a10bd7bdb Merge branch 'master' of github.com:LLNL/H5Z-ZFP
1660d94a4 Fix h5repack test (silx-kit#107)
fd01bf1d7 mention generic interface
8d5ec2e74 Update docs (silx-kit#106)
c76f847d9 Added new endianness test (silx-kit#102)
8acf8244b fix reading of byte-swapped input files (silx-kit#95) (silx-kit#101)
62ab4eb6d Minor code clean-up. (silx-kit#103)
60032f640 Bugfix/hdf5 1.14.0 (silx-kit#99)
8fad85d72 CMake: (fix) MPI parallel HDF5 1.14.0 (silx-kit#97)
e81aec114 Don't flag a skipped test as a failed test.  (silx-kit#94)

git-subtree-dir: src/H5Z-ZFP
git-subtree-split: 092190c38d5760b3212ce4d96cced767b90aa189
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add tests compression is actually working

2 participants