[Staging] Exercise Code Reference preview lifecycle - #93
Closed
sirreal wants to merge 13 commits into
Closed
Conversation
The staging lifecycle needs a fork head distinct from its base. Change one PHPDoc sentence so the parser input and exact source SHA can be verified without changing executable Core behavior.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
The validator forced one worker even though the pinned CLI warns that low worker counts can deadlock on file locks. A ready server could then stop answering health checks and invalidate every snapshot. Use the CLI default and lock that command line down.
GitHub exposes four CPUs, so Playground selected three workers and exported a malformed SQLite database in both staging builds. Invoke the pinned programmatic API with its recommended six workers and validate with the same count. If this is wrong, every reference route dies with a database error.
Playground exports a live filesystem after running the Blueprint. Multiple build workers left SQLite corrupt after the full reference import. Build with one worker, then boot the finished snapshot with six. If this regresses, every reference route dies before publication.
The staging base moved past the fixture branch. GitHub will not emit pull-request workflows for a conflicted fork, so the label lifecycle cannot run. Merge the trusted staging base without changing the fork's parser fixture. This keeps the PR mergeable and leaves the head repository untrusted.
GitHub emits the fork events but skips the build job. Guessing at the compound condition wastes staging runs. Report only the evaluated booleans from an unprivileged temporary job. The diagnostic is removed after the false term is known.
The diagnostic found the false term: fork pull-request runs resolve repository variables from the fork, not the base repository. Remove the temporary job. Keeping diagnostic workflow code would not fix the activation contract.
Fork pull-request contexts cannot see the base repository variable. Before changing the trigger architecture, test whether the existing read-only token can read that non-secret value through GitHub's API. Report only the status and exact-true result. Remove the probe after the capability is known.
The read-only fork token receives HTTP 403 from the base repository variable endpoint. The API cannot supply the missing activation signal without more authority. Remove the temporary probe. Keeping it would add noise without a viable gate.
The latest-wins test needs a new fork head while the label remains present. Change parser-visible prose without changing executable Core behavior so the obsolete run must yield to the new SHA.
Advisory mode needs a real behavioral failure, not a mocked status. Rename the parsed representative function so import still completes but the required route and search result disappear.
The validation-failure fixture has one purpose and must not survive the staging test. Restore the representative function name or the next preview cannot prove the required route and local search behavior.
Code Reference documentation previewStatus: Expired This pull request is closed or merged. Its Code Reference preview expired and is no longer live. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Staging-only pull request for the Code Reference Playground preview acceptance gate. The sole source change rewrites one PHPDoc sentence so the workflow must check out and parse an exact fork head SHA.
Do not merge. This pull request will be used to demonstrate label-triggered build, reuse, forced rebuild, latest-wins cancellation, stale and expired comment states, and cleanup.