Only run x86 build in github actions if x64 build succeeds - #349
Merged
Conversation
I rarely care about the status of the x86 builds, so this commit only runs them if the x64 builds succeed. If the x64 build is successful but the x86 build is not, the cache for the x64 build should kick in and the x86 build should follow shortly after, if it's necessary to iterate on it. Updated the GitHub Actions workflow so x86 only runs after x64 succeeds. Changed: - Split the old matrix job into two explicit jobs: build-x64 and build-x86. - Added needs: build-x64 on the x86 job, which enforces the dependency.
Owner
|
Thanks, @Peter0x44! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I rarely care about the status of the x86 builds, so this commit only runs them if the x64 builds succeed. If the x64 build is successful but the x86 build is not, the cache for the x64 build should kick in and the x86 build should follow shortly after, if it's necessary to iterate on it.
Updated the GitHub Actions workflow so x86 only runs after x64 succeeds.
Changed:
This should speed up claude's work in claude/init-project-setup-TGhNx
Where it can be observed the x64 build is over 2x as fast as the x64 build (I do not know why).