Repository navigation
fix(daily-checkin): verify a week of health email reports, not two - #197
Merged
Merged
Conversation
…verifies one sent operator report per Melbourne date, and a two-row page could only ever confirm the two newest days, so a gap three days back stayed invisible. Eight UTC
Contributor
Author
🤖 MERGED
GitHub merged this pull request. No material findings were recorded. Review completed. No material findings. |
Resolve test conflict with #199. Claude-Session: https://claude.ai/code/session_01AkTC7eqkf2tpVZJhYDU2YL
Resolve test conflict with #196. Claude-Session: https://claude.ai/code/session_01AkTC7eqkf2tpVZJhYDU2YL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Closes #194
❓ Type of change
📚 Description
The daily check-in gate expects one sent operator report per Melbourne date, but the probe only ever read the two newest rows:
A gap three days back could never show up, so continuity was unverifiable. Eight UTC days is the smallest bound that always covers seven Melbourne dates, and
report_dateis the primary key ofdaily_health_checks, so the row cap can never hide an in-window date. The query now lives beside the other built queries where it can be asserted on through the export.The skill's gate wording never named a visible window, so it needed no change. One uncertainty: this sandbox has no outbound network, so the Nuxt test environment could not boot here; the vitest suite runs in CI where it does.