Repository navigation
fix(collections): retire five stale collections - #326
Merged
Merged
Conversation
Redirect the old featured trio to category pages, answer 410 for the two that no page absorbed, and soft-delete all five in migration 0130.
Collaborator
Author
🤖 REVIEWING · 35% · Git worktree ready
Next: Review the diff.
Leave unchecked to finish Review after merge. |
harlan-zw
added
the
harlan-agent-pending
harlan-github-agent
Bot
added
harlan-agent-running
The featured endpoint and the curator counts read live collections. Retiring the trio would empty the homepage band and drop a trust signal. Pages render noindex,follow and leave the authors sitemap. The 410 middleware also matches the %40 form.
harlan-github-agent
Bot
added
harlan-agent-running
Contributor
🤖 MERGED
GitHub merged this pull request.
62c2396f-b83f-4afc-87e7-f6a10e072f52 Selected findings run after merge and open separate pull requests. |
harlan-github-agent
Bot
added
harlan-agent-blocked
2 tasks done
harlan-github-agent
Bot
removed
the
harlan-agent-running
1 task done
harlan-github-agent
Bot
added
harlan-agent-running
harlan-github-agent
Bot
removed
the
harlan-agent-ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❓ Type of change
📚 Description
Two stale collection pages still returned 200 and sat in the authors sitemap. The old featured trio needs a different treatment.
/api/collections/featuredreads onlyharlan-zwrows withfeatured = 1. Production returns exactly the three-stackcollections. If they were soft-deleted, the homepage band would show "No collections are featured right now." Also,curator_countandcurator_reason_countcount live collections only. Retiring the trio would remove a trust signal that some Skills use for indexability.So the trio stays live and featured in D1. No 301, no soft delete. Their pages render
noindex,follow, and the authors sitemap drops them./@harlan-zw/agent-building-stacknoindex,follow/@harlan-zw/agent-workflow-stacknoindex,follow/@harlan-zw/typescript-engineering-stacknoindex,follow/@harlan-zw/apple-apps/@harlan-zw/knowledge-workspaceThe 410 middleware also matches the percent-encoded
/%40harlan-zw/...form.Both groups live in
shared/retired-collections.ts, with a dated comment for why the trio stays. #325's retired sitemap should read the retired group only.Loose end:
scripts/seed-homepage-collections.sqlstill recreates retired slugs if rerun. Other retired slugs already behave that way, so I left it.📝 Migration
migration-namingfails until #320 and #322 merge, because 0128 and 0129 are missing.