Repository navigation
fix(ci): treat the default trending board as an alias - #334
Merged
Merged
Conversation
harlan-github-agent
Bot
added
the
harlan-agent-review-required
Contributor
🤖 MERGED
GitHub merged this pull request. No material findings were recorded. 735e56e4-4856-4e74-a854-18a63900ec58 |
harlan-github-agent
Bot
added
harlan-agent-running
harlan-github-agent
Bot
removed
the
harlan-agent-ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❓ Type of change
📚 Description
Deploy run 36697133297 failed the edge cache check with
shared-cache-entryfor/skills/trendingand?range=month. #322 made month the default range, so both paths render one board and share a title and canonical by design.The check now treats the bare path and the default range as aliases, reading the default from
shared/trending-range.ts. Any other paths that share a title and canonical still fail.Canonical equality alone cannot tell an alias from a real collision: a collision serves one body for every path, so the canonicals match too. Only knowing the default range separates them. Say if you want the canonical rule anyway.