Repository navigation
fix(sentry): drop the MCP probe 406 from beforeSend - #359
Merged
Merged
Conversation
harlan-github-agent
Bot
added
harlan-agent-running
Contributor
Author
🤖 MERGED
GitHub merged this pull request. No material findings were recorded. 4c0661c5-0315-4e41-93ab-5aa11af92dba |
harlan-github-agent
Bot
added
harlan-agent-ready
harlan-github-agent
Bot
removed
the
harlan-agent-ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Closes #357
❓ Type of change
📚 Description
The daily-checkin routine flagged SKILLD-35: an Accept-less
GET /api/mcpprobe archives a new unresolved Sentry issue even though the transport already answered the probe with an intended 406. The streamable transport raises the same error it returns, so Nitro forwards it to Sentry as unhandled and every bot probe files a duplicate of a response the client already got:The POST probe that misses one of the two accepted types carries the same prefix ('Not Acceptable: Client must accept both application/json and text/event-stream'); both strings are in the installed SDK 1.30.1, so the filter matches the prefix. The page-level 406 ('Supported types: text/html, text/markdown, text/plain') does not match and still lands.
This drops the signature next to the KV-write and upstream-outage drops from #176. One thing to know: the match is a message prefix, so an SDK release that rewords the refusal would start landing again and resurface at check-in.