Repository navigation
fix(registry): restore Skill pages broken by behavior rules - #436
Merged
Merged
Conversation
Nitro rewrites the text `import.meta.env` inside skilld-protocol's bundled rules to `globalThis._importMeta_.env`. The rules then fail their own lowercase check, detectBehaviors throws, and every Skill page answers 503. Patch the literal so the bundler cannot reach it, and make a rules failure return no behaviors instead of a 503.
harlan-github-agent
Bot
added
harlan-agent-running
Contributor
🤖 MERGED
GitHub merged this pull request. No material findings were recorded. Review completed. No finding above 80/100. |
harlan-github-agent
Bot
removed
harlan-agent-running
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Related to #425
❓ Type of change
📚 Description
Every Skill page in production answers 503 since #425 deployed. Nitro rewrites the text
import.meta.envinsideskilld-protocol's bundled behavior rules toglobalThis._importMeta_.env. The rules then fail their own "patterns are lowercase" check, sodetectBehaviorsthrows on every Skill page request.skilld-protocol@2.5.0splits the literal, so the bundler cannot rewrite it. The bundled rule keepsimport.meta.env.skillPageBehaviorsnow returns no behaviors and emits askill-behaviorsfailure event if the rules throw. The behaviors panel is optional and must never take the Skill page down.Follow-up: the same literal belongs in
skilld-dev/skilld, so the nextskilld-protocolrelease no longer needs this patch.