Skip to content

perf(d1): omit unused award board reads - #622

Merged
harlan-zw merged 1 commit into
mainfrom
perf/award-query-reads
Oct 11, 2026
Merged

harlan-zw merged 1 commit into
mainfrom
perf/award-query-reads

Conversation

@harlan-zw

Copy link
Copy Markdown
Collaborator

🔗 Linked issue

Follow-up to #620.

❓ Type of change

  • 📖 Documentation
  • 🐞 Bug fix
  • 👌 Enhancement
  • ✨ New feature
  • 🧹 Chore
  • ⚠️ Breaking change

📚 Description

Hourly awards load Repository boards and fallback Skills, then discard them. Awards now use a shared named-Skill loader that preserves board ranking, windows, and top-starred demotion.

A read-only production comparison returned the same 60 award sightings. D1 reads fell from 99,272 to 31,634 rows, and queries fell from 24 to 12. No indexes or migrations change.

🤖 AI disclosure: Harlan Agent Kit modified this description. My AI open-source policy.

@harlan-zw harlan-zw added the harlan-agent-review Pull request triage requires an adversarial Review. Adding this label manually always forces one. label Oct 11, 2026
@harlan-zw

Copy link
Copy Markdown
Collaborator Author

Agent verification, using read-only queries against production D1:

The old full-board path and the named-only path returned identical 60 award sightings, including board, rank, and Skill identity. Both used Unix time 1791684954 for ranking windows.

Per award-sighting load Before After
Queries 24 12
Rows read 99,272 31,634
Sum of D1 statement durations 276.3 ms 99.8 ms

Every statement reported zero rows written. These timings cover one execution per path, not latency percentiles. Background jobs remained active.

The comparison called the actual loaders through a read-only D1 adapter. Raw SQL, bound parameters, metadata, and sightings are retained in the session scratchpad.

@harlan-github-agent harlan-github-agent Bot added harlan-agent-review-required Pull request triage requires an adversarial Review for this head commit. and removed harlan-agent-review Pull request triage requires an adversarial Review. Adding this label manually always forces one. labels Oct 11, 2026
@harlan-github-agent

harlan-github-agent Bot commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor

🤖 MERGED

Harlan Agent Kit posted this automated review. It is not Harlan's personal review or approval. AI open source policy. Last updated: 2026-10-11 03:23 UTC.

GitHub merged this pull request.

No material findings were recorded.

01d3ec97-5832-4184-bb44-6c8c7fbe0fe9

@harlan-github-agent harlan-github-agent Bot added harlan-agent-ready The automated Review passed every gate on this head commit. and removed harlan-agent-review-required Pull request triage requires an adversarial Review for this head commit. labels Oct 11, 2026

@harlan-github-agent harlan-github-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Harlan Agent Kit posted this automated review. AI open source policy.

Automated Review: READY.

Read the Review results

@harlan-zw
harlan-zw merged commit e40eeaf into main Oct 11, 2026
8 checks passed
@harlan-github-agent harlan-github-agent Bot removed the harlan-agent-ready The automated Review passed every gate on this head commit. label Oct 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant