Using packaging.version instead of distutils - #312
Merged
Conversation
jayqi
force-pushed
the
packaging-version
branch
from
October 4, 2023 15:46
5461761 to
ce44912
Compare
Contributor
Author
|
@smarie I've rebased this PR on the current state of the main branch. You need to hit a button in the PR UI to approve the CI to run, since I'm an external contributor to this repo. |
Contributor
Author
|
Hi @smarie — bumping this PR. It should be up-to-date with the main branch, and you need to approve the CI run in GitHub because I'm an external contributor. |
This was referenced Oct 8, 2023
Owner
|
Indeed @jayqi . Thanks ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates from distutils to packaging.version for comparing versions. This follows the recommendations from the distutils deprecation warnings. Distutils is deprecated, and is removed in the upcoming Python 3.12 (pytest-cases is incompatible with Python 3.12 for this reason).
This is an alternative implementation to PR #303, which uses a replacement of
LooseVersion. Because this package is simply comparing pytest package versions, which are all PEP 440 compliant,LooseVersionis not required, and the more standardpackagingpackage is sufficient.Closes #297, closes #307