Clarified how to customize or add a new view - #18
Merged
Conversation
Owner
|
thanks @professor for the pull request. This is actually an issue, ExceptionNotification should be able to prepend the view paths by its own, without having the user add an initializer. |
smartinez87
added a commit
that referenced
this pull request
Jul 19, 2011
Clarified how to customize or add a new view
Author
|
Thanks for the update, Todd On Tue, Jul 19, 2011 at 12:09 PM, smartinez87 <
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found the README not to be clear about how to add a new section. I was not the only one.
See:
http://stackoverflow.com/questions/5389754/custom-partials-in-exception-notification-in-rails-3
I'm hoping this will make it easier for the next person.
BTW, I think the README here (https://github.com/rails/exception_notification) should be removed and just reference your repo. It was on the third read of the page that I noticed that the "official" documentation was on your repo.