Skip to content

Clarified how to customize or add a new view - #18

Merged
smartinez87 merged 2 commits into
smartinez87:masterfrom
professor:master
Jul 19, 2011
Merged

Clarified how to customize or add a new view#18
smartinez87 merged 2 commits into
smartinez87:masterfrom
professor:master

Conversation

@professor

Copy link
Copy Markdown

I found the README not to be clear about how to add a new section. I was not the only one.

See:
http://stackoverflow.com/questions/5389754/custom-partials-in-exception-notification-in-rails-3

I'm hoping this will make it easier for the next person.

BTW, I think the README here (https://github.com/rails/exception_notification) should be removed and just reference your repo. It was on the third read of the page that I noticed that the "official" documentation was on your repo.

@smartinez87

Copy link
Copy Markdown
Owner

thanks @professor for the pull request. This is actually an issue, ExceptionNotification should be able to prepend the view paths by its own, without having the user add an initializer.
Merging this and once we fix the issue we should remove that from the Readme.

smartinez87 added a commit that referenced this pull request Jul 19, 2011
Clarified how to customize or add a new view
@smartinez87
smartinez87 merged commit 47e4c2b into smartinez87:master Jul 19, 2011
@professor

Copy link
Copy Markdown
Author

Thanks for the update,

Todd

On Tue, Jul 19, 2011 at 12:09 PM, smartinez87 <
reply@reply.github.com>wrote:

thanks @professor for the pull request. This is actually an issue,
ExceptionNotification should be able to prepend the view paths by its own,
without having the user add an initializer.
Merging this and once we fix the issue we should remove that from the
Readme.

Reply to this email directly or view it on GitHub:

#18 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants