Repository navigation
Delete unused ChromeRow fields, surplus-join branch, and narrating chrome.rs comments - #143
Merged
Merged
Conversation
…rome comments ChromeRow.painted and undo_offset were never read; the only caller used .text. joins_only_on_surplus was always false, so the surplus-join path never ran. Footer undo stays in draw.rs. Co-authored-by: Saeed <smarzban@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: Saeed <smarzban@users.noreply.github.com>
smarzban
marked this pull request as ready for review
October 7, 2026 07:25
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Subtraction-only cleanup in
src/ui/board/chrome.rs. No user-visible behavior change. The painted status row is untouched.Verified and then deleted:
joins_only_on_surplusalways returnedfalse(ChromeRowPartis onlyNoticeorMessage), so the surplus-join branch never ran.ChromeRow.paintedandundo_offsetwere written and never read. The only caller used.text. Footer undo stays computed indraw.rsstatus_row_content.fit_chrome_rownow returns the rowStringdirectly.Notice.undois still read bywant/floor/render(alwaysfalsefrom the only constructor) and is left as-is.Did not unify this with
draw.rsstatus_row_content. Did not edit files already open on #142, #126, or #120.Test plan
cargo fmt --check— passcargo clippy --all-targets -- -D warnings— pass (Finisheddevin 20.11s, no warnings)cargo test— pass: lib 511, integration 597, queue_board_loop 12, plus CLI/demo/starter/update suites; 0 failedHERDR_ENVunset; no host-path change)cd site && npm ci && npm test && npm run build— not applicable (site/unchanged)