Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes findings 1–3 of #174 (finding 4, the sidebar not keeping the done drawer, stays as designed).
What changed
?):ctrl+freadsarchive / restore (archived: d drawer), so it says where archived tasks live.greadsfold inbox; archived when drawer open.ctrl+son a marked set that holds done tasks now says so on the status row:started N · skipped M done (ctrl+n or ctrl+o reopens them). This also covers a set of only done tasks, which used to do nothing with no message. Without marks, and for skipped started/blocked/review tasks, nothing changes.Docs:
keys.md,board.md, CHANGELOG (Unreleased › Fixed), and the web demo's help rows and bulk start message (the demo uses bare keys,n or o).Labels are kept to ≤ 38 cells so they fit the 58-cell help card (
help_card_lines_fit_the_modal_body_at_every_size). The existing help-search test typeddrawer; that now also matchesctrl+f, which sorts first and pusheddone drawerbelow the compact card. The test now typesdone drawer.Proof
queue_board_verbs::bulk_start_names_skipped_done_marks_on_the_status_rowandqueue_board_verbs::help_names_where_archived_tasks_live_and_what_g_folds. Both fail with the fix reverted by hand, and pass with it.cargo fmt --check && cargo clippy --all-targets -- -D warnings && cargo test: green. Also green:cargo clippy --all-targets --target x86_64-pc-windows-gnu -- -D warnings,site: npm test(49/49) andnpm run test:parity(46/46).Before / after
Binaries:
/tmp/tsk-t215-before(origin/main 39e3a8e, release) and/tmp/tsk-t215-after(this branch, release). Each runs against its own seeded state (/tmp/tsk-t215-state-before,-after), with T1 ready and T2/T3 done on the desk. Scenario:1,d,shift+M, mark T1, T3 and T2, thenctrl+s. Real Herdr pane captures:Before (main): T1 starts, the two done marks are dropped silently. The status row only shows
desk.After (branch):
Help,
?then typearchive. Before:After:
How to test
Already running in Herdr. Workspace of T215 (
w9F), tabs before and after. Each tab has a board open on the desk with the done drawer open and T1, T3, T2 marked (multi-select · 3 selected).ctrl+sin each. Expected: before showsdeskon the status row; after showsstarted 1 · skipped 2 done (ctrl+n or ctrl+o reopens them).?and typearchive. Compare thectrl+fandgrows with the captures above.escesccloses Help.From scratch, against throwaway state only:
bash /tmp/tsk-t215-seed.sh # recreates /tmp/tsk-t215-state-{before,after}: T1 ready, T2+T3 done (desk) env TSK_STATE_DIR=/tmp/tsk-t215-state-before TSK_CONFIG_DIR=/tmp/tsk-t215-state-before /tmp/tsk-t215-before env TSK_STATE_DIR=/tmp/tsk-t215-state-after TSK_CONFIG_DIR=/tmp/tsk-t215-state-after /tmp/tsk-t215-afterOn each board:
1(desk),d(drawer),shift+M, move to T1 and pressspace, do the same on T3 and T2, then pressctrl+s. Read the status row above the footer. Check the docs insite/src/content/docs/docs/keys.md(Board table and the multi-select paragraph) andboard.md.