Repository navigation
Stop growing the pool when thread creation fails - #80
Open
mikamikasuki wants to merge 1 commit into
Open
mikamikasuki wants to merge 1 commit into
mikamikasuki wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A failed thread spawn restores the pool counters but leaves the loop testing a cached thread limit. Persistent spawn failures therefore spin while holding the executor mutex, preventing existing workers from draining the queue.
Stop pool growth after the failed spawn and limit update. This releases the mutex; it does not guarantee task execution when no worker can be created. The native regression forces thread creation to fail in an isolated child: it times out before the fix and exits successfully afterward.
Existing tests, 13 doctests, strict clippy, formatting, and the WASM all-target check pass.
Fixes #79.
Prepared with AI assistance.