Repository navigation
ci: give the dev sync and release jobs their environment secrets - #4
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
BryanLawless
added a commit
that referenced
this pull request
Nov 3, 2026
Promotes the dev sync and release secrets fix (#4). Merge with a merge commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first
Mainrun after the promotion failed in Merge main into dev. The calledsync-dev.ymljob received an emptySNAPFLOW_AUTOMATION_PRIVATE_KEY, even though its job setsenvironment: automation. The release-please job in the same run read the same secret fine, because it's defined directly inmain.yml.sync-dev.ymlnow runs as its own workflow on pushes tomain, so it reads theautomationenvironment directly. It never needed anything frommain.yml.main.ymlnow passessecrets: inherittorelease.yml, which needs release-please's outputs and thebetaenvironment's R2 and TUF keys. The zizmorsecrets-inheritfinding is suppressed with a reason.Checked locally: actionlint passes, and zizmor reports only the existing low-severity
self-repositoryhints.