Repository navigation
Do not include build artifacts in the npm package - #1786
Conversation
WoLewicki
left a comment
There was a problem hiding this comment.
Wouldn't it be better to exclude it in files field of package.json? Something like this is done e.g. here: https://github.com/software-mansion/react-native-screens/blob/cc5de7ba28e90ecce9bbb3464ef0a625eaae032f/package.json#L43
|
@WoLewicki That seems reasonable too, both places seem to accomplish roughly the same thing, and both files are present in the codebase, so it's a matter of stylistic preference. I can change the PR to do it in |
|
I think it would be a better option since I don't see |
|
Updated |
Co-authored-by: Wojciech Lewicki <wojciech.lewicki@swmansion.com>
|
Does iOS have a similar build dir to exclude? |
|
I think not since I don't see any excludes in other repos. I think we can merge it now 🎉 Thanks for your contribution! |
|
Thanks for the feedback. Looking forward to the next release. |
Fixes #1785