Skip to content

Do not include build artifacts in the npm package - #1786

Merged
WoLewicki merged 3 commits into
software-mansion:mainfrom
TikiTDO:patch-1
Jul 14, 2022
Merged

WoLewicki merged 3 commits into
software-mansion:mainfrom
TikiTDO:patch-1

Conversation

@TikiTDO

@TikiTDO TikiTDO commented Jun 8, 2022

Copy link
Copy Markdown
Contributor

Fixes #1785

@WoLewicki WoLewicki left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be better to exclude it in files field of package.json? Something like this is done e.g. here: https://github.com/software-mansion/react-native-screens/blob/cc5de7ba28e90ecce9bbb3464ef0a625eaae032f/package.json#L43

@TikiTDO

TikiTDO commented Jul 14, 2022

Copy link
Copy Markdown
Contributor Author

@WoLewicki That seems reasonable too, both places seem to accomplish roughly the same thing, and both files are present in the codebase, so it's a matter of stylistic preference. I can change the PR to do it in package.json if you'd like.

@WoLewicki

Copy link
Copy Markdown
Member

I think it would be a better option since I don't see .npmignore used too much in other repos.

@TikiTDO

TikiTDO commented Jul 14, 2022

Copy link
Copy Markdown
Contributor Author

Updated

Comment thread package.json Resolved
Co-authored-by: Wojciech Lewicki <wojciech.lewicki@swmansion.com>
@TikiTDO

TikiTDO commented Jul 14, 2022

Copy link
Copy Markdown
Contributor Author

Does iOS have a similar build dir to exclude?

@WoLewicki

Copy link
Copy Markdown
Member

I think not since I don't see any excludes in other repos. I think we can merge it now 🎉 Thanks for your contribution!

@WoLewicki
WoLewicki merged commit 4d3c521 into software-mansion:main Jul 14, 2022
@TikiTDO

TikiTDO commented Jul 14, 2022

Copy link
Copy Markdown
Contributor Author

Thanks for the feedback. Looking forward to the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NPM library ships with unnecessary android build files

2 participants