Skip to content

chore(size): re-record the ledger on next @ 3b7ea81 after the 2026-10-29 batch - #4412

Merged
ryansolid merged 2 commits into
nextfrom
claude/project-thread-x1ore2-size-ledger
Oct 29, 2026
Merged

ryansolid merged 2 commits into
nextfrom
claude/project-thread-x1ore2-size-ledger

Conversation

@ryansolid

Copy link
Copy Markdown
Member

Before: the size check fails on every PR against next. The 2026-10-29 bug-fix batch (#4401, #4397, #4383, #4393, #4406) merged without re-recording the ledger, as the maintainer asked, so next sits over several caps and recorded minified sizes.

After: every cap is CI brotli + 10 B rounded up to 0.01 KB, never lowered, and every recorded minified equals the CI measurement on next @ 3b7ea81. The size check on new PRs measures growth from there.

How: the numbers come from the size job on next @ 3b7ea81 (job 123403325357). Each changed limit: gets a dated ledger line in scripts/size/scenarios.js, and the frozen floors move in floor-caps.json. No source changes.

The biggest moves, in brotli:

Size-Exception: one batch re-record after the 2026-10-29 bug-fix batch, which the maintainer asked for (2026-10-29). The frozen floors that move are the signals core floor (7.44 → 7.53 KB), the app render floor (9.75 → 9.88 KB), hydrating (18.49 → 18.80 KB), page base (33.37 → 33.78 KB) and page live (37.75 → 38.67 KB). Each one is the CI measurement on next @ 3b7ea81 + 10 B.


Generated by Claude Code

…-29 batch

Caps at CI brotli + 10 B rounded up to 0.01 KB, recorded minified =
CI measured (next @ 3b7ea81, size job 123403325357).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2
Size-Exception in the PR body: one batch re-record after the
2026-10-29 bug-fix batch.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2
@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Size (brotli, eager entry chunk)

scenario head vs base minified vs base minified vs recorded cap lazy chunks (not counted)
signals: core floor (createSignal/Memo/Effect/Root/flush) 7.51 KB 0 B 0 B 0 B 7.53 KB ✅
signals: + createStore 15.04 KB 0 B 0 B 0 B 15.06 KB ✅
signals: + isPending/latest 11.02 KB 0 B 0 B 0 B 11.03 KB ✅
signals: + until/refresh (truth readers, no optimism) 8.14 KB 0 B 0 B 0 B 8.16 KB ✅
app: render + one signal (the simple-app floor) 9.87 KB 0 B 0 B 0 B 9.88 KB ✅
app: hydrating (no stores) with Show/For/Loading/Errored/lazy 18.79 KB 0 B 0 B 0 B 18.80 KB ✅ lazy-page.js 0.04 KB
app: hydrating + every store primitive family 32.41 KB 0 B 0 B 0 B 32.42 KB ✅ lazy-page.js 0.04 KB
app: CSR with Show/For/Loading/Errored/lazy 13.52 KB 0 B 0 B 0 B 13.53 KB ✅ lazy-page.js 0.04 KB
app: CSR, observe tier (same app on the observe artifacts) 15.28 KB 0 B 0 B 0 B 15.29 KB ✅ lazy-page.js 0.04 KB
app: CSR, observe tier + attribution engine enabled 29.84 KB 0 B 0 B 0 B 29.85 KB ✅ lazy-page.js 0.04 KB
app: compiled floor (one template, one text hole, one delegated click) 10.06 KB 0 B 0 B 0 B 10.07 KB ✅
app: compiled CSR (JSX todo app: spread/merge/omit, events, class/style, keyed For, Show, Loading + lazy, store) 26.38 KB 0 B 0 B 0 B 26.40 KB ✅ stats.js 0.18 KB
app: compiled hydrating (the same JSX todo app through hydrate(), compiled hydratable) 32.57 KB 0 B 0 B 0 B 32.58 KB ✅ stats.js 0.20 KB
frames: eager client consumer (frames client + transport, lazy codec) 11.75 KB 0 B 0 B 0 B 11.77 KB ✅
page: base server components (hydrating + dynamic + frames + sf reference) 33.77 KB 0 B 0 B 0 B 33.78 KB ✅ assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.06 KB, trace.js 9.03 KB, wire.js 3.47 KB
page: live server components (base + live/GET + action + isPending/latest) 38.66 KB 0 B 0 B 0 B 38.67 KB ✅ assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.06 KB, trace.js 9.04 KB, wire.js 3.47 KB
page: compiled base server components (the base page as JSX: templates with class/style/attributes/events, For/Show; no spread) 35.68 KB 0 B 0 B 0 B 35.69 KB ✅ assets.js 0.78 KB, decode.js 7.09 KB, regions.js 1.06 KB, sc-comments.js 0.20 KB, trace.js 8.99 KB, wire.js 3.47 KB
page: compiled live server components (the compiled base page + live/GET + action + isPending/latest) 42.59 KB 0 B 0 B 0 B 42.61 KB ✅ eager (counted): web.js 22.69 KB; assets.js 0.78 KB, decode.js 7.09 KB, regions.js 1.07 KB, sc-comments.js 0.19 KB, trace.js 9.05 KB, wire.js 3.47 KB
page: base + router (base page + @solidjs/router: createRouter, two routes, preload, useNavigate) 41.30 KB 0 B 0 B 0 B 41.32 KB ✅ assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.06 KB, server.js 1.03 KB, serverForms.js 3.57 KB, trace.js 9.01 KB, wire.js 3.48 KB
page: live + router (live page + @solidjs/router: createRouter, two routes, preload, useNavigate) 48.27 KB 0 B 0 B 0 B 48.29 KB ✅ eager (counted): client.js 27.86 KB; assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.07 KB, server.js 1.03 KB, serverForms.js 3.30 KB, trace.js 9.00 KB, wire.js 3.49 KB
server: floor (getRequestEvent + isServer) 1.27 KB 0 B 0 B 0 B 1.34 KB ✅
server: renderToString (the server-render floor) 22.79 KB 0 B 0 B 0 B 22.80 KB ✅

Bundled with Rolldown (what Vite ships), brotli q11, decimal KB. A scenario fails only when it is over its brotli cap and its minified size is more than 20 B over the minified recorded with the cap; over the cap within that allowance is brotli layout noise and passes with a warning. Caps and their recorded minified in scripts/size/scenarios.js; the floor and page caps in floor-caps.json are frozen (lower only, or Size-Exception: in the PR body). npm run ratchet lowers caps per RC; it never raises one (scripts/size/README.md).

@coveralls

coveralls commented Oct 29, 2026 •

Copy link
Copy Markdown

Coverage Report for CI Build 40864714159

Coverage remained the same at 78.516%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 1355
Covered Lines: 1125
Line Coverage: 83.03%
Relevant Branches: 1084
Covered Branches: 790
Branch Coverage: 72.88%
Branches in Coverage %: Yes
Coverage Strength: 30.06 hits per line

💛 - Coveralls

@codspeed

codspeed Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Merging this PR will improve performance by 9.36%

1 warning

⚠️ 3 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

⚡ 1 improved benchmark
✅ 199 untouched benchmarks
⏩ 5 skipped benchmarks1

Performance Changes

Benchmark BASE HEAD Efficiency
⚡ arrow in template 11.9 ms 10.9 ms +9.36%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.


Comparing claude/project-thread-x1ore2-size-ledger (c7ad263) with next (3b7ea81)

Open in CodSpeed

Footnotes

  1. 5 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Copy link
Copy Markdown
Member Author

The CodSpeed dip on createStore setter: delete + set one root key (−14%) is noise. This PR only edits scripts/size/ and no package code changes. CodSpeed also says base and head ran on different runner types. Every other check is green, including the size and floor-caps check.


Generated by Claude Code

@ryansolid
ryansolid merged commit 9545058 into next Oct 29, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants