Repository navigation
fix(store): fix traversed returning duplicate values - #843
Merged
Merged
Conversation
Pull Request Test Coverage Report for Build 1819680927Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
otonashixav
marked this pull request as draft
February 9, 2022 18:27
Contributor
Author
|
I left #824 in this by accident, going to just keep it to fixing traversed and leave the types to later Edit: done |
otonashixav
force-pushed
the
fix-set-store-traversed
branch
from
February 9, 2022 18:35
1e5569c to
5a89487
Compare
otonashixav
force-pushed
the
fix-set-store-traversed
branch
from
February 9, 2022 18:37
5a89487 to
43a5113
Compare
otonashixav
marked this pull request as ready for review
February 9, 2022 18:37
Member
|
Thanks. Looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #840
Also made the type ofWill make a PR after the other store type PRs are donetraversedreflect the keys traversed e.g.