Repository navigation
Add bmv2 libsai switch & port attributes - #281
Merged
chrispsommers merged 9 commits intoNov 22, 2022
Merged
Conversation
…to satisfy initialization requirements for PTF and Pytest frameworks. Modified PTF tests to use correct base class which exploits these attributes. Removed one "chmod" command in Makefile which caused repeated "make all" to fail (discovered while implementing this fix).
Collaborator
Author
|
@aputriax please review as well. |
chrispsommers
marked this pull request as ready for review
November 10, 2022 23:30
aputriax
reviewed
Nov 11, 2022
…ad of explicit values, which will allow for different results on various targets.
aputriax
reviewed
Nov 14, 2022
aputriax
approved these changes
Nov 14, 2022
Closed
vmytnykx
reviewed
Nov 14, 2022
vmytnykx
left a comment
vmytnykx
left a comment
Collaborator
There was a problem hiding this comment.
@chrispsommers thanks for making those changes. In general it looks good with minor comments.
… remove warnings due to type conversions, print our OIDs in Pytest for easier interpretation.
vmytnykx
approved these changes
Nov 15, 2022
Collaborator
Author
|
Hi @marian-pritsak could you please take a quick look at this? It's needed to unblock some other work, thanks! |
Contributor
|
@marian-pritsak , can you review this? |
lguohan
reviewed
Nov 16, 2022
lguohan
reviewed
Nov 16, 2022
lguohan
reviewed
Nov 16, 2022
…view feedback. Minor refactoring of templates and code-generator to promote maintainability.
chrispsommers
added a commit
that referenced
this pull request
Nov 22, 2022
* Refactor saichallenger-client to use a [puboished] base image for faster builds. Publish base image only. Build both of these images in bmv2-CI. * Fix dockerfile tags. * Build base image before building final image. Fix some comments. * Replace use of chrissommers dockerhub registry with sonicdash.azurecr.io (some missed items in PR225). (#274) Co-authored-by: Chris Sommers <chrispsommers@gmail.com> * Change ACL list match to prefix list for IPs (#269) The SAI API change opencomputeproject/SAI#1630 Signed-off-by: Marian Pritsak <marianp@mellanox.com> * Add bmv2 libsai switch & port attributes (#281) * Fix issue 235 - added more switch and port attributes to bmv2 libsai to satisfy initialization requirements for PTF and Pytest frameworks. Modified PTF tests to use correct base class which exploits these attributes. Removed one "chmod" command in Makefile which caused repeated "make all" to fail (discovered while implementing this fix). * Restore chmod in makefile from prev. commit, CI breaks. * Add pytest mark "switch" and add tests for switch and port attributes. * Fixed spelling of setUp/tearDown. Removed redundant case. * Changed assertions on switch attributes to check for "not None" instead of explicit values, which will allow for different results on various targets. * Restored test assertions to !=0 * Changes per review feedback - make dummy object_id creation explicit, remove warnings due to type conversions, print our OIDs in Pytest for easier interpretation. * Split DASH libsai fixed APIs from utils.cpp into separate file per review feedback. Minor refactoring of templates and code-generator to promote maintainability. Co-authored-by: Chris Sommers <chrispsommers@gmail.com> * Merge from main * Fix DASH ACL implementation and add testcases (#265) * Fixbug: SAI Server crash on DASH ACL API 1. Fix duplicate SAI ID 2. Wrong search action 3. Double delete entry if SAI write error 4. Wrong format of error message Signed-off-by: Ze Gan <ganze718@gmail.com> Signed-off-by: Marian Pritsak <marianp@mellanox.com> Signed-off-by: Ze Gan <ganze718@gmail.com> Co-authored-by: Chris Sommers <chrispsommers@gmail.com> Co-authored-by: Marian Pritsak <marianp@mellanox.com> Co-authored-by: Ze Gan <ganze718@gmail.com>
vijasrin
pushed a commit
to vijasrin/DASH
that referenced
this pull request
Dec 8, 2022
* Fix issue 235 - added more switch and port attributes to bmv2 libsai to satisfy initialization requirements for PTF and Pytest frameworks. Modified PTF tests to use correct base class which exploits these attributes. Removed one "chmod" command in Makefile which caused repeated "make all" to fail (discovered while implementing this fix). * Restore chmod in makefile from prev. commit, CI breaks. * Add pytest mark "switch" and add tests for switch and port attributes. * Fixed spelling of setUp/tearDown. Removed redundant case. * Changed assertions on switch attributes to check for "not None" instead of explicit values, which will allow for different results on various targets. * Restored test assertions to !=0 * Changes per review feedback - make dummy object_id creation explicit, remove warnings due to type conversions, print our OIDs in Pytest for easier interpretation. * Split DASH libsai fixed APIs from utils.cpp into separate file per review feedback. Minor refactoring of templates and code-generator to promote maintainability. Co-authored-by: Chris Sommers <chrispsommers@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #235. Added fake switch & port attributes to bmv2 libsai in order to satisfy PyTest and PTF base classes.
SaiHelperSimplifiedas PTF base class to replace workaround use ofThriftInterfaceDataPlanebase class.