Repository navigation
docs: disclose price list download in restricted-network guide - #21
Merged
Merged
Conversation
The guide said Sortie reaches only the destinations a workflow names, but the model price list download from raw.githubusercontent.com is on by default. Describe it, what happens when it is unreachable, and how to turn it off or replace it. Also note the Gemini CLI telemetry exception, rename the guide to "How to ..." like its siblings, give it a weight that does not collide with the Kubernetes guide, and drop a stray blank line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Scope & Context
Type: Fix
Intent: The network-restricted guide said Sortie reaches only the destinations a workflow names, but Sortie downloads a model price list from
raw.githubusercontent.comat startup and every 24 hours by default. An operator following the guide would allow-list the configured hosts and then see a recurringprice table download failedwarning. The guide now lists that connection, says what happens when it is unreachable, and gives the three ways to turn it off or replace it.Related Issues: sortie-ai/sortie#1396
🧭 Reviewer Guide
Complexity: Low
Entry Point
content/guides/run-in-restricted-networks.md: the new table row and the "Decide about the price list download" subsection under "Plan Sortie's connections", plus the matching checklist item. Smaller corrections in the same file:weight: 185, which no longer collides with the Kubernetes guide (190).content/guides/_index.mdonly loses a stray trailing blank line.Sensitive Areas
content/guides/run-in-restricted-networks.md: the retry schedule (1 minute, doubling up to 1 hour) and the rule that aprice_table.replace_urldownload runs regardless ofprice_table.fetchare taken frominternal/pricing/download.goandinternal/pricing/rates.goin sortie-ai/sortie.