Fixed Temorary Config Conext Manager - #2018
Merged
philip-paul-mueller merged 1 commit intoMay 30, 2025
Merged
Conversation
…not handled correctly.
phschaad
enabled auto-merge
May 26, 2025 08:56
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
May 26, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
May 26, 2025
iomaganaris
pushed a commit
to GridTools/dace
that referenced
this pull request
Aug 19, 2025
The two context managers for temporary configuration contexts, i.e. `set_temporary()` and `temporary_config()`, contained a bug. If the context, i.e. the `with`-clause, was left through an exception then the old configuration state was not restored. This could lead to the leaking of configuration options. Co-authored-by: Philip Mueller <philip.paul.mueller@bluemain.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two context managers for temporary configuration contexts, i.e.
set_temporary()andtemporary_config(), contained a bug.If the context, i.e. the
with-clause, was left through an exception then the old configuration state was not restored.This could lead to the leaking of configuration options.