Skip to content

Use os.UserHomeDir() in document - #906

Closed
micnncim wants to merge 1 commit into
spf13:masterfrom
micnncim:use-homedir
Closed

micnncim wants to merge 1 commit into
spf13:masterfrom
micnncim:use-homedir

Conversation

@micnncim

Copy link
Copy Markdown

Related to #853, replaced mitchellh/go-homedir with os.UserHomeDir() in README.md.

@CLAassistant

CLAassistant commented Jul 14, 2019 •

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@umarcor

umarcor commented Jul 14, 2019

Copy link
Copy Markdown
Contributor

Hi @micnncim! I am not sure about this PR making sense on its own.

In #853, this change is applied along with making the codebase compatible for go 1.10, 1.11 and 1.12.

In #876, this change is applied along with deprecating go 1.10 and 1.11, thus making cobra >=1.12 only.

Since this PR replaces mitchellh/go-homedir with os.UserHomeDir without further modifications, I assume that you agree with #876. If so, I'd suggest to close this issue and review #876 instead.

@micnncim

micnncim commented Jul 15, 2019 •

Copy link
Copy Markdown
Author

Thank you @umarcor! I don't notice #876 so will close this PR.

@micnncim micnncim closed this Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants