Support exposing enums from ObjC via Bridging headers - #149
Merged
Conversation
polac24
changed the title
polac24
marked this pull request as ready for review
June 20, 2022 20:40
PatrikBillgren
previously approved these changes
Jun 29, 2022
PatrikBillgren
left a comment
PatrikBillgren
left a comment
Contributor
There was a problem hiding this comment.
Looks really good! Approved, I just noticed one minor nit in a comment
Co-authored-by: PatrikBillgren <PatrikBillgren@users.noreply.github.com>
Collaborator
Author
|
@PatrikBillgren, can you please reapprove after my typo fix? |
CognitiveDisson
approved these changes
Aug 24, 2022
Contributor
|
@polac24 Should we merge it? |
Collaborator
Author
|
@CognitiveDisson, yes. let me merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part III (out of IV) of #140 fix
-Swift.hand-Swift.h.md5. Because the former could contain absolute paths, the latter file is used in a dependency fingerprint (just like.swiftmodulefiles) - its content is just the same as the .swiftmodule's override (a fingerprint of the target).hdependency, check if an override is available. If so, its content is used for the fingerprint-Swift.h.md5is automatically placed next to the-Swift.honly for a .framework, a developer that wants to cover that for a static library, has to manually add an extraditto(similar tocp) build step to move-Swift.h.md5along-Swift.h. Required steps are documented in Readme.md. This scenario can be considered (only static library + exposing enum via a bridging header) as an edge case - very unlikely to happen.This part unblocks
rake e2e:run_standaloneadded in #147.