Options button not working for contacts

[sunjam]

#1326 related. I cannot access "Options" for any specific contact. Clicking the button does nothing. Was hoping to block some users I'm seeing in public, but do not follow.

[christianbundy]

is this in a stable Patchwork or the new experimental beta?

[sunjam]

Experimental beta pre-rust branch. It is in the linked issue.

…

On Sat, Nov 21, 2020, 8:06 AM Christian Bundy ***@***.***> wrote: is this in a stable Patchwork or the new experimental beta? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1328 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AANUKZRLTE52BQROWICT26DSQ7QPDANCNFSM4T53LRPQ> .

[christianbundy]

cc: @staltz @black-puppydog

[staltz]

Pre-rust or post-rust?

[black-puppydog]

Actually I've had this for a loooong time but I asked about it on ssb and we couldn't replicate so I always kinda just assumed it was sth wrong with my setup, or I had somehow upset my npm or something.

[black-puppydog]

Oh. What I wrote there was... false. :P

Actually @soapdog confirmed that but I must have missed that notification.

%ySQfyTDAMI97BKQaQ9zl6QHChWMjdJzZ3qjZCT6hz7s=.sha256

[sunjam]

Pre-rust or post-rust?

Pre-rust. See this linked thread from my first post for complete background.

#1326 related. I cannot access "Options" for any specific contact. Clicking the button does nothing. Was hoping to block some users I'm seeing in public, but do not follow.

[black-puppydog]

I looked at this one a bit yesterday, but I didn't have much time to get to the bottom of it.
I basically just got to this line:

patchwork/lib/depject/contact/html/follow-toggle.js

Lines 97 to 105 in 54a329a

	electron.remote.getCurrentWindow().webContents.getZoomFactor((factor) => {
	const menu = electron.remote.Menu.buildFromTemplate([
	{
	type: 'radio',
	label: i18n('Neutral'),
	checked: status == null,
	click: () => setStatus(id, null, { states, ignores })
	},
	{

This line is executed on the client (i.e. in the "browser") and is querying the zoomFactor from the remote, i.e. the "server".
From what I can tell, this is done through binding via mutant.

The second aspect (besides mutant) to this call is that recently, electron has refactored the getter functions to be JS get properties. Not sure if that matters.

In any case, the callback given to the getter seems to never be called.

However: if I inspect the window, and evaluate electron.remote.getCurrentWindow().webContents.zoomFactor by hand, it returns 1 correctly.

Not really conclusive, but that's where I'm at right now.

[soapdog]

This is happening for me and I am using the release version. I'm not building or running from source, I'm getting the latest version pre-built from this repo.

[christianbundy]

@soapdog Clarification: are you running v3.18.0 or v3.18.1-beta.1?

[soapdog]

@christianbundy Patchwork 3.18.1-beta.1

[black-puppydog]

but @christianbundy I've been seeing this for much longer (see above)

[black-puppydog]

@sunjam in case you're not reading on ssb, I think I fixed this in #1368. If you want to test this, let me know if you need help. :)