Skip to content

Use invariant case conversion #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ssg merged 2 commits into from
Jul 17, 2026
Merged

Use invariant case conversion #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f13379f
use invariant case conversion
skacurt Jul 16, 2026
ca5c3d7
add test for Turkish-I locale issue
skacurt Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/CodingAlphabet.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ public CodingAlphabet(int length, string alphabet, bool caseInsensitive = false)
char c = alphabet[i];
if (caseInsensitive && char.IsLetter(c))
{
char c2 = char.IsUpper(c) ? char.ToLower(c) : char.ToUpper(c);
char c2 = char.IsUpper(c) ? char.ToLowerInvariant(c) : char.ToUpperInvariant(c);
if (alphabet.Contains(c2))
{
throw new ArgumentException($"Case-sensitivity can't be selected with an alphabet that contains both cases of the same letter", nameof(caseInsensitive));
Expand Down
18 changes: 18 additions & 0 deletions test/CodingAlphabetTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,10 @@ class DummyAlphabet(string alphabet) : CodingAlphabet(10, alphabet, caseInsensit
{
}

class DummyAutoAlphabet(string alphabet, bool caseInsensitive) : CodingAlphabet(alphabet.Length, alphabet, caseInsensitive)
{
}

[Test]
public void Ctor_WithBothCasesOfLettersAndCaseInsensitive_ShouldThrow()
{
Expand All @@ -43,4 +47,18 @@ public void Ctor_ProperArguments_ShouldNotThrow()
{
Assert.DoesNotThrow(() => new DummyAlphabet("01234567ab"));
}

[Test]
[SetCulture("tr-TR")]
public void Ctor_ShouldNotThrow_On_Turkish_Locale_With_Lowercase_I()
{
Assert.DoesNotThrow(() => new DummyAutoAlphabet("i", true));
}

[Test]
[SetCulture("tr-TR")]
public void Ctor_ShouldNotThrow_On_Turkish_Locale_With_Uppercase_I()
{
Assert.DoesNotThrow(() => new DummyAutoAlphabet("I", true));
}
}