Skip to content

chore: bump Rust edition to 2024 and apply cargo fix + clippy updates#899

Open
Saul-STFC wants to merge 2 commits into
stackabletech:mainfrom
Saul-STFC:rust-2024-upgrade
Open

chore: bump Rust edition to 2024 and apply cargo fix + clippy updates#899
Saul-STFC wants to merge 2 commits into
stackabletech:mainfrom
Saul-STFC:rust-2024-upgrade

Conversation

@Saul-STFC
Copy link
Copy Markdown

@Saul-STFC Saul-STFC commented Jun 2, 2026

  • Apply cargo fix --edition changes
  • Use && let chaining instead of nested if let (Clippy suggested)
  • Fix Rust 2024 drop order warning by dropping unused binding

Part of stackabletech/issues#832

Description

Please add a description here. This will become the commit message of the merge request later.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

- Apply `cargo fix --edition` changes
- Use `&& let` chaining instead of nested `if let` (Clippy suggested)
- Fix Rust 2024 drop order warning by dropping unused binding
sbernauer
sbernauer previously approved these changes Jun 3, 2026
@sbernauer sbernauer moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Development: In Review

Development

Successfully merging this pull request may close these issues.

3 participants